Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buttons until required inputs supplied #126

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

@mccalluc mccalluc marked this pull request as ready for review November 4, 2024 15:46
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one change request

dp_creator_ii/app/dataset_panel.py Show resolved Hide resolved
@mccalluc mccalluc dismissed ekraffmiller’s stale review November 4, 2024 21:11

fixed. (Going forward, stale reviews should be dismissed automatically.)

Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it and the validation is working as expected 👍

@mccalluc mccalluc merged commit 14f06a1 into main Nov 5, 2024
2 checks passed
@mccalluc mccalluc deleted the 125-disable-define-analysis-button branch November 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
2 participants