For October 22 #64

mccalluc · 2024-10-16T19:26:18Z

Heard that the really granular PRs were hard to review, so I'll try to just put the next batch of work in one, if it seems related.

Original description:

Fix Clean up "Select Dataset" after big merge #63

Move calculated fields to the next page in the flow, since we don't really need them here.

File name doesn't seem to be preserved when the uploaded file is stored locally: After upload, I'm seeing the name as 0.csv. For now, let's just not worry about echoing that back to the user, since we will be showing them their column headers.

dp_creator_ii/tests/test_app.py

ekraffmiller

Reviewed with Chuck, looks good

mccalluc added 2 commits October 16, 2024 15:15

clean up dataset page, and move half-baked to analysis

02c4ec9

move test_app assertion

41b28db

mccalluc requested a review from ekraffmiller October 16, 2024 19:26

ekraffmiller reviewed Oct 18, 2024

View reviewed changes

dp_creator_ii/tests/test_app.py Show resolved Hide resolved

mccalluc mentioned this pull request Oct 18, 2024

Strengthen CSV end-to-end test #76

Closed

mccalluc requested a review from ekraffmiller October 18, 2024 19:06

merge

3e2c3f6

mccalluc changed the title ~~Cleanup select dataset UI~~ For October 22 Oct 18, 2024

mccalluc added 7 commits October 21, 2024 09:10

app_test uses fixture, not generated file. Fix #76

a0acf21

check branch coverage. Fix #74

a397c77

label log slider

29c69f0

move to separate file

fd384ee

id parameter

9a11890

lower and upper parameter

11af899

rename and reorg

090f329

This was linked to issues Oct 21, 2024

Enable branch coverage checks #74

Closed

Strengthen CSV end-to-end test #76

Closed

Labels on logarithmic slider #70

Closed

remove commented-out block

d84235b

mccalluc linked an issue Oct 21, 2024 that may be closed by this pull request

Move get_args out of dataset_ui #51

Closed

mccalluc added 10 commits October 21, 2024 12:48

columns checkbox group

6c73ef1

columns_ui

0872248

stub per-column controls

ea963b6

fix warning on startup, because there is a default contrib

ea0a3db

add a test that exercises conversion error handling

bab08ae

execise Template param checks

9ea7449

playwrite test of dynamic form

6fc6140

test the log slider: click on the bar and it moves half-way

756e270

comment linting

eb5cc9b

Move stray files to utils directory

582d5bc

mccalluc added 8 commits October 22, 2024 09:47

move tests dir up and out

2d352b9

Remove top-level coverage skip

8514ed7

remove redundant css

07ab303

collect info from dynamic form elements

490cb99

numeric values

4828da7

pull columns into module

2cc8842

rename

5717be7

add pragma to fix coverage

b7b7e18

This was linked to issues Oct 22, 2024

Add end to end test for slider #71

Closed

coverage omit should only cover UI files #73

Closed

ekraffmiller approved these changes Oct 22, 2024

View reviewed changes

mccalluc merged commit 7631b8c into main Oct 22, 2024
2 checks passed

mccalluc deleted the 63-cleanup-select-dataset-ui branch October 22, 2024 19:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For October 22 #64

For October 22 #64

mccalluc commented Oct 16, 2024 •

edited

Loading

ekraffmiller left a comment

For October 22 #64

For October 22 #64

Conversation

mccalluc commented Oct 16, 2024 • edited Loading

ekraffmiller left a comment

Choose a reason for hiding this comment

mccalluc commented Oct 16, 2024 •

edited

Loading