This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Count #3
Open
cwagaman
wants to merge
11
commits into
main
Choose a base branch
from
make_count
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Count #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwagaman
requested review from
pdurbin,
raprasad,
ecowan,
Shoeboxam,
andrewvyrros,
gracetian6 and
silviacasac
July 13, 2021 05:09
uploaded modified tex doc, and uploaded pdf generated from modified tex doc
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Jul 19, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
SalilVadhan
reviewed
Aug 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files:
This upload contains the proof for the function make_count, specifically the version of the function found at this GitHub permalink.
During the proof process, some questions arose. They are noted in the tex file using the format "
\question{...}
". The questions also appear in the pdf file generated from the tex file; they are displayed in red text and are prepended by "Question:".The functions, traits, and other terms used in the pseudocode can be found in the
"List of definitions used in the pseudocode" Overleaf documentpseudocode-defns branch. Likewise, definitions used in the proof can be found in the "List of definitions used in the proofs" Overleaf document. Please let me know if you need access to either one.Feel free to reach out here or on Slack with any questions. Thanks!
Update: September 6, 2021
This proof document now incorporates all suggestions made as of September 6, 2021.
Two questions (both noted in red text in the document):
Update: September 23, 2021
This proof document now incorporates all suggestions made as of September 23, 2021. This includes the suggestions made by Marco Gaboardi. Currently, there is no remaining feedback to incorporate. Probably a final review is needed before we merge this into main and close the PR, but currently I have no more work to do on this.