-
Notifications
You must be signed in to change notification settings - Fork 971
docs: swap example file storage away from deprecated lib #6953
Conversation
Thanks for the pull request, @stvstnfrd! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
Note: This work is being done on behalf of OpenCraft and should, presumably, be covered under their CLA agreement. CC: @openedx/cla-problems |
Looks good +1
|
@openedx/cla-problems I've tried re-running the CLA check, but since the runner provides no visual feedback or indicator, I can't tell if it's actually working or not. Related: Because the CLA check looks like it's been implemented with a webhook and not a Github Action, contributors can't manually rerun the check. If this were implemented with the latter, contributors could re-run the check explicitly, instead of relying on the "edit the title", which is a crude hack. Further, implementing this as a GHA would provide explicit, visual indication that the job was actually rerun (or not). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 -- this is ready to merge once openedx/edx-platform#32646 merges.
-
I tested this-- actual change is on build: swap default file storage away from deprecated lib openedx/edx-platform#32646, which is being reviewed separately. - I read through the code
-
I checked for accessibility issuesN/A - Updates documentation
The S3BotoStorage backend was deprecated in favor of the S3Boto3Storage backend. This change updates the example backend to reference the latter. Fixes: FAL-3431 Fixes: public-engineering/128
@pomegranited All green and ready to merge. |
The S3BotoStorage backend was deprecated in favor of the S3Boto3Storage backend. This change updates the example backend to reference the latter. Fixes: FAL-3431 Fixes: public-engineering/128
The S3BotoStorage backend was deprecated in favor of the S3Boto3Storage backend. This change updates the example backend to reference the latter.
This is meant to accompany openedx/edx-platform#32646
Fixes: FAL-3431
Fixes: public-engineering/128
Configuration Pull Request
Make sure that the following steps are done before merging: