Discovery: Use Django LocaleMiddleware instead of django-lang-pref-middleware

[sarina]

My recollection is this custom middleware was written prior to Django having its own locale middleware, or at least, the Django native middleware didn't do what we want.

The last time this code was meaningfully updated was in 2014, when it was extracted from edx-platform. We should take a step back and investigate if there are Django native patterns around localization we should follow, to bring our project up to Django standards and avoid maintenance burden of custom middleware.

Can we replace this middleware with Django's LocaleMiddleware? Docs are here.

[sarina]

@feanil I don't see an Aximprovements team project to add this to

[feanil]

I've added it.

[irtazaakram]

Hey @sarina, I couldn’t find where this package is used in the Open edX repositories. The only usage I found was in this edX repository: edx-analytics-dashboard.

[sarina]

Hi! If it's not used anywhere maybe we can just remove it.

…

On Tue, Oct 29, 2024 at 2:17 AM Irtaza Akram ***@***.***> wrote: Hey @sarina <https://github.com/sarina>, I couldn’t find where this package is used in the Open edX repositories <https://github.com/search?q=org%3Aopenedx+django-lang-pref-middleware&type=code>. The only usage I found was in this edX repository: edx-analytics-dashboard <https://github.com/edx/edx-analytics-dashboard/blob/b180478255911345b91399a90ac3f254dfff02de/analytics_dashboard/core/middleware.py#L9> . — Reply to this email directly, view it on GitHub <#264 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPEWJJZ25CATQC3IGAIVZTZ54SARAVCNFSM6AAAAABOF2E6ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGMYDMMBWGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>