BOM-1537 : Upgrade to Python 3.8 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzulqarnain1
force-pushed
the
zulqarnain/BOM-1537
branch
from
8175a1d to
3fd43ce
Compare
|
@mzulqarnain1 See also #454 #453 for some potential warnings related to migration. |
mzulqarnain1
force-pushed
the
zulqarnain/BOM-1537
branch
5 times, most recently
from
bbbe558 to
734bca2
Compare
mzulqarnain1
requested review from
jmbowman,
awais786 and
UsamaSadiq
and removed request for
jmbowman
awais786
reviewed
Apr 25, 2020
awais786
reviewed
Apr 25, 2020
| @@ -146,15 +146,15 @@ def POST(self): | |||
| querydict_to_multidict(self._request.FILES, wrap=DjangoUploadedFile), | |||
| ) | |||
|
|
|||
| @lazy | |||
| def body(self): # pylint: disable=method-hidden | |||
| @property | |||
There was a problem hiding this comment.
please add a reason for this change.
There was a problem hiding this comment.
Both of these are marked as property in class we are inheriting from so pylint suggested making it property in child class too.
awais786
reviewed
Apr 25, 2020
| @@ -139,7 +138,7 @@ def load_classes(cls, fail_silently=True): | |||
| """ | |||
| all_classes = itertools.chain( | |||
| pkg_resources.iter_entry_points(cls.entry_point), | |||
| (entry_point for identifier, entry_point in cls.extra_entry_points), | |||
| (entry_point for identifier, entry_point in iter(cls.extra_entry_points)), | |||
There was a problem hiding this comment.
This is a lazy member of our class which returns a list when called, but pylint doesn't consider it an iterable and warns, so wrapping it in iter() does the trick.
awais786
reviewed
Apr 25, 2020
| @@ -54,22 +54,18 @@ def __new__(cls, scope, user_id, block_scope_id, field_name, block_family='xbloc | |||
| @abstractmethod | |||
| def get(self, key): | |||
| """Reads the value of the given `key` from storage.""" | |||
There was a problem hiding this comment.
I think you can disable the pass warning instead of removing.
There was a problem hiding this comment.
Should I go on and re-add all the pass?
mzulqarnain1
force-pushed
the
zulqarnain/BOM-1537
branch
from
734bca2 to
23e43fd
Compare
mzulqarnain1
force-pushed
the
zulqarnain/BOM-1537
branch
from
23e43fd to
70065e0
Compare
morenol
reviewed
Apr 29, 2020
morenol
approved these changes
Apr 30, 2020
jmbowman
reviewed
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-1537