Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport adding Badge issuance to Redwood #2528

Conversation

KyryloKireiev
Copy link
Contributor

This is backport of the commit da22842 to redwood.master

Original PR: #2489

Description:
This pull request implements openedx/platform-roadmap#280 feature.

Changes:

Creates new badges application.
Extends documentation with badges section.
Extends set of credentials
Related documentation:
See temporarily deployed documentation https://raccoongang.github.io/credentials/badges/index.html

Related PR's:

openedx/openedx-events#303
openedx/edx-platform#34749

kyrylo-kh and others added 2 commits July 23, 2024 17:24
* feat: add badges feature
* chore: update dummy translations
* refactor: squash migrations + text cleanup + resolve conflict
* docs: documentation update

---------

Co-authored-by: Andrii <andrii.hantkovskyi@raccoongang.com>
Co-authored-by: Andrii Hantkovskyi <andrii.hantkovskyi@github.com>
Co-authored-by: KyryloKireiev <kirillkireev888@gmail.com>
Co-authored-by: wowkalucky <wowkalucky@gmail.com>
Co-authored-by: GlugovGrGlib <glugov1998@gmail.com>
@KyryloKireiev KyryloKireiev requested a review from a team as a code owner July 23, 2024 14:46
@openedx-webhooks
Copy link

Thanks for the pull request, @KyryloKireiev!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 23, 2024
@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Jul 24, 2024
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at this PR now.

@deborahgu deborahgu assigned deborahgu and unassigned deborahgu Jul 25, 2024
@deborahgu
Copy link
Member

I asked a question about this on discourse. I would love if you contributed to talk about why you want the backport. I just want to get signoff from the larger community for a large feature backport.

@deborahgu deborahgu added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Aug 28, 2024
@cmltaWt0
Copy link

Decided to not backport it to the Redwood release.

@cmltaWt0 cmltaWt0 closed this Sep 20, 2024
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Status: Backlog
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants