From 8b31c1052bab442e5cc4344c6594633838332c2b Mon Sep 17 00:00:00 2001
From: MueezKhan246 <93375917+MueezKhan246@users.noreply.github.com>
Date: Tue, 10 Sep 2024 14:22:47 +0500
Subject: [PATCH] Making unencrypted sap client credentials nullable (#2236)

* refactor: making unencrypted credentials nullable so after removing refs tests can run
---
 CHANGELOG.rst                                 |  4 ++++
 enterprise/__init__.py                        |  2 +-
 .../migrations/0023_auto_20240909_1556.py     | 23 +++++++++++++++++++
 .../sap_success_factors/models.py             |  6 +++--
 4 files changed, 32 insertions(+), 3 deletions(-)
 create mode 100644 integrated_channels/sap_success_factors/migrations/0023_auto_20240909_1556.py

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 29762d812..002c361f9 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -17,6 +17,10 @@ Unreleased
 ----------
 * nothing unreleased
 
+[4.25.6]
+----------
+* refactor: making unencrypted credentials nullable so after removing refs tests can run
+
 [4.25.5]
 ----------
 * feat: changing django enterprise customer summary columns
diff --git a/enterprise/__init__.py b/enterprise/__init__.py
index 2d8e12f09..45e7ced47 100644
--- a/enterprise/__init__.py
+++ b/enterprise/__init__.py
@@ -2,4 +2,4 @@
 Your project description goes here.
 """
 
-__version__ = "4.25.5"
+__version__ = "4.25.6"
diff --git a/integrated_channels/sap_success_factors/migrations/0023_auto_20240909_1556.py b/integrated_channels/sap_success_factors/migrations/0023_auto_20240909_1556.py
new file mode 100644
index 000000000..042e01ef8
--- /dev/null
+++ b/integrated_channels/sap_success_factors/migrations/0023_auto_20240909_1556.py
@@ -0,0 +1,23 @@
+# Generated by Django 3.2.23 on 2024-09-09 15:56
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('sap_success_factors', '0022_auto_20240906_1349'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='key',
+            field=models.CharField(blank=True, default='', help_text='OAuth client identifier.', max_length=255, null=True, verbose_name='Client ID'),
+        ),
+        migrations.AlterField(
+            model_name='sapsuccessfactorsenterprisecustomerconfiguration',
+            name='secret',
+            field=models.CharField(blank=True, default='', help_text='OAuth client secret.', max_length=255, null=True, verbose_name='Client Secret'),
+        ),
+    ]
diff --git a/integrated_channels/sap_success_factors/models.py b/integrated_channels/sap_success_factors/models.py
index aaa8ff365..002ee57ce 100644
--- a/integrated_channels/sap_success_factors/models.py
+++ b/integrated_channels/sap_success_factors/models.py
@@ -79,7 +79,8 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
         blank=True,
         default='',
         verbose_name="Client ID",
-        help_text=_("OAuth client identifier.")
+        help_text=_("OAuth client identifier."),
+        null=True
     )
 
     decrypted_key = EncryptedCharField(
@@ -142,7 +143,8 @@ def encrypted_key(self, value):
         blank=True,
         default='',
         verbose_name="Client Secret",
-        help_text=_("OAuth client secret.")
+        help_text=_("OAuth client secret."),
+        null=True
     )
 
     decrypted_secret = EncryptedCharField(