-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: send LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED from the correct p…
…lace. I had originally tried emitting this event from the `/cancel_enrollment` API endpoint, but in reality the LMS and Enterprise dashboards were calling the `/change_enrollment` endpoint. The former is called by enterprise-subsidy on transaction reversal, i.e. NOT learner-initiated. The latter is learner-initiated, and that's the original goal of this work. Changes in this commit: * Update the event emission to live closer to the fulfillment model itself (inside `revoke()`). * Ensure that when an EnterpriseCourseEnrollment is unenrolled, the related Fulfillment subclass is revoked. This is a best-effort to improve internal consistency during learner-initiated unenrollment. * Consumers of the various enrollment models are now expected to call helper functions to unenroll/reenroll/revoke/reactivate rather than directly set internal fields. ENT-9213
- Loading branch information
Showing
4 changed files
with
135 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters