From f96942a45deef2465d09ce11cf88cedb3782a482 Mon Sep 17 00:00:00 2001 From: Muhammad Sameer Amin <35958006+sameeramin@users.noreply.github.com> Date: Fri, 27 Sep 2024 15:24:17 +0500 Subject: [PATCH 1/2] feat: remove logging to debug SAP SuccessFactors transmission issues --- CHANGELOG.rst | 4 +++ enterprise/__init__.py | 2 +- .../exporters/learner_data.py | 36 ------------------- 3 files changed, 5 insertions(+), 37 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 4b9a5aea7c..9fe39f608e 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -17,6 +17,10 @@ Unreleased ---------- * nothing unreleased +[4.25.18] +---------- +* feat: remove logging to debug SAP SuccessFactors transmission issues + [4.25.17] --------- * feat: add pagination to the support tool customer list diff --git a/enterprise/__init__.py b/enterprise/__init__.py index a2b9cf09d4..e5066343d0 100644 --- a/enterprise/__init__.py +++ b/enterprise/__init__.py @@ -2,4 +2,4 @@ Your project description goes here. """ -__version__ = "4.25.17" +__version__ = "4.25.18" diff --git a/integrated_channels/integrated_channel/exporters/learner_data.py b/integrated_channels/integrated_channel/exporters/learner_data.py index 070a800512..04385833ea 100644 --- a/integrated_channels/integrated_channel/exporters/learner_data.py +++ b/integrated_channels/integrated_channel/exporters/learner_data.py @@ -124,15 +124,6 @@ def bulk_assessment_level_export(self): # Create a record of each subsection from every enterprise enrollment for enterprise_enrollment in enrollment_queryset: if not LearnerExporter.has_data_sharing_consent(enterprise_enrollment): - # Adding logging to debug the issue we are having with a customer using SAPSF channel - LOGGER.info(generate_formatted_log( - self.enterprise_configuration.channel_code(), - self.enterprise_configuration.enterprise_customer.uuid, - None, - None, - f'[SAPSF] Transmission skipped for {enterprise_enrollment.enterprise_customer_user.user_id}' - 'due to missing data sharing consent.' - )) continue assessment_grade_data = self._collect_assessment_grades_data(enterprise_enrollment) @@ -201,16 +192,6 @@ def single_assessment_level_export(self, **kwargs): detect_grade_updated=self.INCLUDE_GRADE_FOR_COMPLETION_AUDIT_CHECK, ) - # Adding logging to debug the issue we are having with a customer using SAPSF channel - LOGGER.info(generate_formatted_log( # pragma: no cover - self.enterprise_configuration.channel_code(), - self.enterprise_configuration.enterprise_customer.uuid, - None, - None, - f'[SAPSF] Transmission already sent for {enterprise_enrollment.enterprise_customer_user.user_id}' - f'is_already_transmitted returned {already_transmitted}' - )) - if not (TransmissionAudit and already_transmitted) and LearnerExporter.has_data_sharing_consent( enterprise_enrollment): @@ -221,14 +202,6 @@ def single_assessment_level_export(self, **kwargs): assessment_grade_data=assessment_grade_data, ) if records: - # Adding logging to debug the issue we are having with a customer using SAPSF channel - LOGGER.info(generate_formatted_log( # pragma: no cover - self.enterprise_configuration.channel_code(), - self.enterprise_configuration.enterprise_customer.uuid, - None, - None, - f'[SAPSF] Transmission sent for {enterprise_enrollment.enterprise_customer_user.user_id}' - )) # There are some cases where we won't receive a record from the above # method; right now, that should only happen if we have an Enterprise-linked # user for the integrated channel, and transmission of that user's @@ -524,15 +497,6 @@ def _filter_out_pre_transmitted_enrollments( grade, detect_grade_updated=self.INCLUDE_GRADE_FOR_COMPLETION_AUDIT_CHECK, ): - # Adding logging to debug the issue we are having with a customer using SAPSF channel - LOGGER.info(generate_formatted_log( - self.enterprise_configuration.channel_code(), - self.enterprise_configuration.enterprise_customer.uuid, - None, - None, - f'[SAPSF] Transmission skipped for {enterprise_enrollment.enterprise_customer_user.user_id}' - 'transmission_audit and already_transmitted returned True.' - )) # We've already sent a completion status for this enrollment LOGGER.info(generate_formatted_log( channel_name, enterprise_customer_uuid, lms_user_id, course_id, From b398bf91dff79dba94f8d5992d3da0b52e6792df Mon Sep 17 00:00:00 2001 From: Muhammad Sameer Amin <35958006+sameeramin@users.noreply.github.com> Date: Fri, 27 Sep 2024 19:08:13 +0500 Subject: [PATCH 2/2] chore: bumped version to 4.25.19 --- CHANGELOG.rst | 4 ++++ enterprise/__init__.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index d0a4910371..d72b87f56c 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -17,6 +17,10 @@ Unreleased ---------- * nothing unreleased +[4.25.19] +--------- +* feat: remove logging to debug SAP SuccessFactors transmission issues + [4.25.18] --------- * chore: requirement updates diff --git a/enterprise/__init__.py b/enterprise/__init__.py index e5066343d0..2a77a85887 100644 --- a/enterprise/__init__.py +++ b/enterprise/__init__.py @@ -2,4 +2,4 @@ Your project description goes here. """ -__version__ = "4.25.18" +__version__ = "4.25.19"