Skip to content

Commit

Permalink
docs: update changelog and a comment
Browse files Browse the repository at this point in the history
  • Loading branch information
tecoholic committed May 12, 2023
1 parent 811b828 commit d8b24f4
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Unreleased
* Switch from ``edx-sphinx-theme`` to ``sphinx-book-theme`` since the former is
deprecated

[3.63.0]
--------
feat: enable enrolling leaners to invite_only courses via manage learners view

[3.62.7]
--------
feat: include obsolete attribute in degreed content transmissions
Expand Down
2 changes: 1 addition & 1 deletion enterprise/admin/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ def _enroll_users(
enrollment_reason=None,
sales_force_id=None,
discount=0.0,
force_enrollment=False
force_enrollment=False,
):
"""
Enroll the users with the given email addresses to the course.
Expand Down
17 changes: 14 additions & 3 deletions enterprise/static/enterprise/js/manage_learners.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ function updateCourseData(data) {
var previous_value = $course_mode.val();
applyModes(data.course_modes);
$course_mode.val(previous_value);
/*
* If the course is invite-only, show the force enrollment box.
*/

// If the course is invite-only, show the force enrollment box.
if (data.invite_only) {
$("#id_force_enrollment").parent().show();
}
Expand Down Expand Up @@ -140,6 +139,18 @@ function loadPage() {
programEnrollment.$control.oldValue = null;
});

// NOTE: As the course details won't be fetched for course id in the CSV
// file, this has a potential side-effect of enrolling learners into the courses
// which might be marked as closed for reasons other then being "Invite Only".
//
// This is considered as a reasonable tradeoff at the time of this addition.
// Currently, the EnrollmentListView does not support invitation only courses.
// This problem does not happen in the Instructor Dashboard because it doesn't
// invoke access checks when calling the enroll method. Modifying the enroll method
// is a high-risk change, and it seems that the API will need some changes in
// the near future anyway - when the Instructor Dashboard is converted into an
// MFE (it could be an excellent opportunity to eliminate many legacy behaviors
// there, too).
$("#id_bulk_upload_csv").change(function(e) {
if (e.target.value) {
var force_enrollment = $("#id_force_enrollment");
Expand Down

0 comments on commit d8b24f4

Please sign in to comment.