-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade course_enrollment from audit to verified #1786
Conversation
16ef915
to
b16820a
Compare
enterprise/utils.py
Outdated
user.username, | ||
course_id, | ||
course_mode, | ||
True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I wonder if it may be slightly more readable to include the kwarg property key when passing True
so that the code is more self-descriptive/documented (e.g., is_active=True
below).
tests/test_enterprise/test_utils.py
Outdated
@override_settings(ENABLE_ENTERPRISE_BACKEND_EMET_AUTO_UPGRADE_ENROLLMENT_MODE=True) | ||
@mock.patch('enterprise.utils.lms_update_or_create_enrollment') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] Similar to the previous comment, I wonder if we should have test cases covering both the feature flag being enabled and disabled to assert on both code baths while both still exist.
Description
If an enterprise learner has enrolled in the audit course mode, we would like to support an automatic upgrade to the paid (verified) enrollment track.
In edx-platform, the
lms_enroll_user_in_course
function is updated tolms_update_or_create_enrollment
to allow for an update to the course_mode.This PR updates the name of the function and any related comments.
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.