Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit learner credit unenrollment event #2190

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

pwnage101
Copy link
Contributor

@pwnage101 pwnage101 commented Jul 31, 2024

event type: org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1
event_name: LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED

The motivation for emitting this event is to support event-driven creation of openedx_ledger.Reversal objects.

ENT-9213

Merging of this PR is blocked until we can merge and release openedx/openedx-events#380

@pwnage101 pwnage101 marked this pull request as draft July 31, 2024 21:22
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9213 branch 7 times, most recently from 184a039 to 6e4b86e Compare August 1, 2024 00:58
@pwnage101 pwnage101 marked this pull request as ready for review August 1, 2024 00:58
setup.py Outdated
def get_requirements(requirements_file):
def load_requirements(*requirements_paths):
Copy link
Contributor Author

@pwnage101 pwnage101 Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes in this file are just cherry-picked from cookiecutter-django-app to bring it up to date and prevent weird issues parsing base.in.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking good to me. Left a clarifying question about the event-tracking requirements constraint.

enterprise/models.py Outdated Show resolved Hide resolved
requirements/common_constraints.txt Outdated Show resolved Hide resolved
event type: org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1
event_name: LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED

The motivation for emitting this event is to support event-driven
creation of openedx_ledger.Reversal objects.

ENT-9213
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9213 branch 2 times, most recently from a939162 to 7780866 Compare September 5, 2024 01:22
@pwnage101 pwnage101 merged commit d880ce8 into master Sep 5, 2024
13 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-9213 branch September 5, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants