Added encrypted credentials column in sap configuration #2208
Conversation
There was a problem hiding this comment.
Looks good but according to this docs you need to register a signal as well to copy data from old fields to the new ones
|
@sameeramin signal is not implemented as what i understood from the doc was that it is needed to implemented if is updated regularly. 'if there is a Django admin page or other form and it is used regularly to create/update rows: |
…Khan/Added-Encrypted-Credentials-Column-In-SAP-Configuration
enterprise/signals.py
Outdated
| if instance.key != instance.decrypted_key: | ||
| instance.encrypted_key = instance.key | ||
| if instance.secret != instance.decrypted_secret: | ||
| instance.encrypted_secret = instance.secret |
There was a problem hiding this comment.
as per discussion in call, please update to refer model attributes here
There was a problem hiding this comment.
@sameenfatima78 updated.
…Khan/Added-Encrypted-Credentials-Column-In-SAP-Configuration
|
@sameenfatima78 i removed the fields from serializer as i was unable to confirm that the endpoint was public through DataDog. i will be adding those in follow up PR. |
MueezKhan246
deleted the
MueezKhan/Added-Encrypted-Credentials-Column-In-SAP-Configuration
branch
Description:
Added encryption fields to the model of SAP config.
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8972