From b17396c47ed33cf5dc00edad06d944d1b55fd0bf Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Mon, 26 Aug 2024 16:47:21 +0500
Subject: [PATCH 1/2] test: Add Node 20 to CI matrix

---
 .github/workflows/ci.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c89822915..5df4f4ceb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,19 +19,20 @@ jobs:
         python-version:
         - '3.11'
         toxenv: [quality, docs, django42-celery53, pii_check]
+        node: [18, 20]
+      continue-on-error: ${{ matrix.node == 20 }}
     env:
       RUNJSHINT: true
     steps:
     - uses: actions/checkout@v2
-    - name: Setup Nodejs Env
-      run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
     - uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
         architecture: x64
-    - uses: actions/setup-node@v2
+    - name: Setup Nodejs
+      uses: actions/setup-node@v4
       with:
-        node-version: ${{ env.NODE_VER }}
+        node-version: ${{ matrix.node }}
     - run: pip install -r requirements/ci.txt
     - name: Run tox
       env:

From 7608cf1654012a27c8222706e073eaeb082e16a9 Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Mon, 26 Aug 2024 17:14:32 +0500
Subject: [PATCH 2/2] refactor: adjusted linespace for workflow

---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5df4f4ceb..928903c52 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ jobs:
         - '3.11'
         toxenv: [quality, docs, django42-celery53, pii_check]
         node: [18, 20]
-      continue-on-error: ${{ matrix.node == 20 }}
+    continue-on-error: ${{ matrix.node == 20 }}
     env:
       RUNJSHINT: true
     steps: