Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added encrypted client secret in sap configuration #2231

Conversation

MueezKhan246
Copy link
Contributor

Description:
Added encrypted client secret in sap configuration and added option to update value where unencrypted columns can be updated
this PR must only be merged when
1st Removing decrypted client secret in sap configuration from code #2228

and then
2nd Migration for removing decrypted client secret in sap configuration #2230
gets deployed

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8972

Copy link
Member

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Base automatically changed from MueezKhan/Migration-For-Removing-Decrypted-Client-Secret-In-SAP-Configuration to master September 6, 2024 08:05
…Khan/Added-Encrypted-Client-Secret-In-SAP-Configuration
@MueezKhan246 MueezKhan246 force-pushed the MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration branch from ac86c9d to 0ddfe45 Compare September 6, 2024 11:56
@MueezKhan246 MueezKhan246 merged commit cba67ec into master Sep 6, 2024
13 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration branch September 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants