-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added encrypted client secret in sap configuration #2231
Merged
MueezKhan246
merged 13 commits into
master
from
MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration
Sep 6, 2024
Merged
Added encrypted client secret in sap configuration #2231
MueezKhan246
merged 13 commits into
master
from
MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration-From-Code' of github.com:openedx/edx-enterprise into MueezKhan/Migration-For-Removing-Decrypted-Client-Secret-In-SAP-Configuration
…Khan/Removing-Decrypted-Client-Secret-In-SAP-Configuration-From-Code
…guration-From-Code' of github.com:openedx/edx-enterprise into MueezKhan/Migration-For-Removing-Decrypted-Client-Secret-In-SAP-Configuration
sameeramin
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
sameenfatima78
approved these changes
Sep 6, 2024
Base automatically changed from
MueezKhan/Migration-For-Removing-Decrypted-Client-Secret-In-SAP-Configuration
to
master
September 6, 2024 08:05
…Khan/Added-Encrypted-Client-Secret-In-SAP-Configuration
MueezKhan246
force-pushed
the
MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration
branch
from
September 6, 2024 11:56
ac86c9d
to
0ddfe45
Compare
MueezKhan246
deleted the
MueezKhan/Added-Encrypted-Client-Secret-In-SAP-Configuration
branch
September 6, 2024 14:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added encrypted client secret in sap configuration and added option to update value where unencrypted columns can be updated
this PR must only be merged when
1st Removing decrypted client secret in sap configuration from code #2228
and then
2nd Migration for removing decrypted client secret in sap configuration #2230
gets deployed
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8972