Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making unencrypted sap client credentials nullable #2236

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Making unencrypted sap client credentials nullable #2236

merged 3 commits into from
Sep 10, 2024

Conversation

MueezKhan246
Copy link
Contributor

@MueezKhan246 MueezKhan246 commented Sep 9, 2024 •
edited
Loading

sameeramin
sameeramin approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@MueezKhan246
Merge branch 'master' of github.com:openedx/edx-enterprise into Mueez…
f46067c 
…Khan/Making-Unencrypted-SAP-Client-Credentials-Nullable
@MueezKhan246 MueezKhan246 merged commit 8b31c10 into master Sep 10, 2024
13 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Making-Unencrypted-SAP-Client-Credentials-Nullable branch September 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameeramin sameeramin sameeramin approved these changes

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MueezKhan246 @sameeramin @sameenfatima78