Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making unencrypted sap client credentials nullable #2236

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Unreleased
----------
* nothing unreleased

[4.25.6]
----------
* refactor: making unencrypted credentials nullable so after removing refs tests can run

[4.25.5]
----------
* feat: changing django enterprise customer summary columns
Expand Down
2 changes: 1 addition & 1 deletion enterprise/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Your project description goes here.
"""

__version__ = "4.25.5"
__version__ = "4.25.6"
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Generated by Django 3.2.23 on 2024-09-09 15:56

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('sap_success_factors', '0022_auto_20240906_1349'),
]

operations = [
migrations.AlterField(
model_name='sapsuccessfactorsenterprisecustomerconfiguration',
name='key',
field=models.CharField(blank=True, default='', help_text='OAuth client identifier.', max_length=255, null=True, verbose_name='Client ID'),
),
migrations.AlterField(
model_name='sapsuccessfactorsenterprisecustomerconfiguration',
name='secret',
field=models.CharField(blank=True, default='', help_text='OAuth client secret.', max_length=255, null=True, verbose_name='Client Secret'),
),
]
6 changes: 4 additions & 2 deletions integrated_channels/sap_success_factors/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
blank=True,
default='',
verbose_name="Client ID",
help_text=_("OAuth client identifier.")
help_text=_("OAuth client identifier."),
null=True
)

decrypted_key = EncryptedCharField(
Expand Down Expand Up @@ -142,7 +143,8 @@ def encrypted_key(self, value):
blank=True,
default='',
verbose_name="Client Secret",
help_text=_("OAuth client secret.")
help_text=_("OAuth client secret."),
null=True
)
sameenfatima78 marked this conversation as resolved.
Show resolved Hide resolved

decrypted_secret = EncryptedCharField(
Expand Down
Loading