fix: Don't import HttpClientError from edx-rest-api-client #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
approved these changes
Sep 24, 2024
edx-rest-api-client was doing a wildcard import of the underlying Slumber exception. This wildcard impart has been droped in the latest release 6.0.0 This change updates the edx-enterprise code to not rely on this indirection to import the exception class.
feanil
force-pushed
the
feanil/remove_unnecessary_dependency
branch
from
47afac6
to
13e58d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edx-rest-api-client was doing a wildcard import of the underlying
Slumber exception. This wildcard impart has been droped in the latest
release 6.0.0
This change updates the edx-enterprise code to not rely on this
indirection to import the exception class.
Relevant change: openedx/edx-rest-api-client@f3a7cd0#diff-d34240bacb445782a73762a7380c1c64efc25ded2afb18245bf2256fda8157ff