Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates get_all_learners to remove _get_implicit_group_members #2262

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 8, 2024

Description

Fixes a reported bug by updating the logic to get the accepted members count from a group.
AttributeError: 'list' object has no attribute 'filter'

Previously, we were attempting to apply a filter on the get_all_learners() method for groups that have applies_to_all_contexts enabled and disabled. However, the get_all_learners method returns a list of all members when a group has applies_to_all_contexts enabled instead of a queryset, which resulted in the error.

This PR updates get_all_learners to remove _get_implicit_group_members which was returning a list.

https://2u-internal.atlassian.net/browse/ENT-9598

Test

  1. add a group to at this link http://localhost:18000/admin/enterprise/enterprisegroup/ and check the box Set group membership to the entire org of learners.
  2. hit the endpoint http://localhost:18000/enterprise/api/v1/enterprise_group/ and verify that you get a valid response and do not see any errors.

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@katrinan029 katrinan029 marked this pull request as ready for review October 8, 2024 18:54
@katrinan029 katrinan029 requested a review from a team October 8, 2024 18:54
@katrinan029 katrinan029 force-pushed the knguyen2/ent-9598 branch 3 times, most recently from 2ead760 to 2d8892a Compare October 8, 2024 19:52
@katrinan029 katrinan029 changed the title fix: update logic to correct getting accepted members count from a group fix: updates get_all_learners to remove _get_implicit_group_members Oct 8, 2024
@katrinan029 katrinan029 merged commit 4731169 into master Oct 8, 2024
14 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9598 branch October 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants