Skip to content

Commit

Permalink
feat: upgrading simple api to drf compatible.
Browse files Browse the repository at this point in the history
  • Loading branch information
awais786 committed Aug 8, 2024
1 parent 4d12abd commit 28afb4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lms/djangoapps/instructor/views/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
from lms.djangoapps.instructor_task.api_helper import AlreadyRunningError, QueueConnectionError
from lms.djangoapps.instructor_task.data import InstructorTaskTypes
from lms.djangoapps.instructor_task.models import ReportStore
from lms.djangoapps.instructor.views.serializer import RoleNameSerializer, UserSerializer, UserAccessSerializer
from lms.djangoapps.instructor.views.serializer import RoleNameSerializer, UserSerializer, AccessSerializer
from openedx.core.djangoapps.content.course_overviews.models import CourseOverview
from openedx.core.djangoapps.course_groups.cohorts import add_user_to_cohort, is_course_cohorted
from openedx.core.djangoapps.course_groups.models import CourseUserGroup
Expand Down Expand Up @@ -996,7 +996,7 @@ class ModifyAccess(APIView):
"""
permission_classes = (IsAuthenticated, permissions.InstructorPermission)
permission_name = permissions.EDIT_COURSE_ACCESS
serializer_class = UserAccessSerializer
serializer_class = AccessSerializer

@method_decorator(ensure_csrf_cookie)
def post(self, request, course_id):
Expand All @@ -1006,7 +1006,7 @@ def post(self, request, course_id):
request.user, 'instructor', course_id, depth=None
)

serializer_data = UserAccessSerializer(data=request.data)
serializer_data = AccessSerializer(data=request.data)
if not serializer_data.is_valid():
return HttpResponseBadRequest(reason=serializer_data.errors)

Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/instructor/views/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Meta:
fields = ['username', 'email', 'first_name', 'last_name']


class UserAccessSerializer(serializers.Serializer):
class AccessSerializer(serializers.Serializer):
unique_student_identifier = serializers.CharField(
max_length=255,
help_text="Email or username of user to change access"
Expand Down

0 comments on commit 28afb4b

Please sign in to comment.