build: swap default file storage away from deprecated lib

[stvstnfrd]

The S3BotoStorage backend was deprecated in favor of the S3Boto3Storage backend. This change updates the default backend to use the latter.

Style: This re-links a relevant comment that had been disconnected during a previous refactoring.

Note: There is a relevant configuration change forthcoming,
but it's docs/comments only.

Fixes: FAL-3431
Fixes: openedx/public-engineering#128

[openedx-webhooks]

Thanks for the pull request, @stvstnfrd! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

[stvstnfrd]

It looks like the primary, related variables (AWS_ACCESS_KEY_ID, AWS_SECRET_ASSESS_KEY, etc.) remain the same in the new backend, but I'll do a deeper dive to confirm compatibility.

[stvstnfrd]

Note: This work is being done on behalf of OpenCraft and should, presumably, be covered under their CLA agreement.

[ChrisChV]

Looks good 👍

I haven't found a way to check if the Deprecation Warning is gone. @stvstnfrd Do you have any idea how to check it?

• I read through the changes.

[stvstnfrd]

Thanks @ChrisChV . I couldn't find it generated anywhere either.

At face value, that configuration wouldn't be used unless one were setting AWS credentials, which presumably shouldn't happen during tests. I don't think the value is ever being tested/mocked elsewhere.

[Agrendalath]

@ChrisChV, @stvstnfrd, I verified that this gets rid of these warnings in a production-like environment. I'll leave the +1 and merge once the CLA check is clear.

[stvstnfrd]

@openedx/cla-problems I've tried re-running the CLA check, but since the runner provides no visual feedback or indicator, I can't tell if it's actually working or not.

Related: Because the CLA check looks like it's been implemented with a webhook and not a Github Action, contributors can't manually rerun the check. If this were implemented with the latter, contributors could re-run the check explicitly, instead of relying on the "edit the title", which is a crude hack. Further, implementing this as a GHA would provide explicit, visual indication that the job was actually rerun (or not).

[stvstnfrd]

@Agrendalath @ChrisChV Suggestions on who to ping from TCRIL about this?

I tagged @openedx/cla-problems previously, per the comment ^, but it's not clear that's still a valid Github Team (it didn't show up in autocomplete and it's not displayed as a hyperlink)... or maybe it is?

[Agrendalath]

@mphilbrick211, could you re-run the CLA check?

@tecoholic, is everything done on our end for the CLA?

[pomegranited]

@stvstnfrd This upgrade is painless, with no required configuration changes. But ops people and @openedx/community-release-managers might wonder if there is, so could you add a link to the django-storages Migration docs in your PR description? That section of the docs has since been removed from the master docs, so it can be a little hard to find.

[Agrendalath]

Rebasing, as the CMS change was merged in #32733.

[Agrendalath]

👍

• I tested this: tested the S3Boto3Storage in the production-like environment
• I read through the code
• I checked for accessibility issues: n/a
• Includes documentation: n/a
• I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

[stvstnfrd]

@Agrendalath Rebased.

@pomegranited Commit message amended to contain docs link.

@ormsbee FYI since related to recent change you made.

[stvstnfrd]

@Agrendalath Ready to merge.

It's weird not having the Big Green Button myself 😜

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.