Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix python deprecation warnings: collections.abc , HTTPResponse.getheaders(), add_custom_parameter #33584

Closed
3 tasks
Tracked by #32888
DanielVZ96 opened this issue Oct 24, 2023 · 1 comment
Closed
3 tasks
Tracked by #32888

fix python deprecation warnings: collections.abc , HTTPResponse.getheaders(), add_custom_parameter #33584

DanielVZ96 opened this issue Oct 24, 2023 · 1 comment

Comments

@DanielVZ96
Copy link
Contributor

These warnings appear during provisioning. They clutters logs and hinder dev experience (#32888).

AC:

  • The warnings stop cluttering logs
    • HTTPResponse.getheaders() is deprecated in urllib3.
    • DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    • DeprecationWarning: The add_custom_parameter API has been deprecated. Please use the add_custom_attribute API.
@DanielVZ96 DanielVZ96 mentioned this issue Oct 24, 2023
Open
@DanielVZ96 DanielVZ96 mentioned this issue Oct 26, 2023
Merged
@DanielVZ96 DanielVZ96 changed the title Fix Python deprecation warnings: collections.abc , HTTPResponse.getheaders(), add_custom_parameter fix python deprecation warnings: collections.abc , HTTPResponse.getheaders(), add_custom_parameter Oct 26, 2023
DanielVZ96 added a commit to DanielVZ96/edx-platform that referenced this issue Nov 1, 2023
@DanielVZ96
chore: ignore HTTPResponse.getheaders() deprecation warning
d2f427a 
related issue: openedx#33584

note: this warning is rased from a third party library (elasticsearch)
DanielVZ96 added a commit to DanielVZ96/edx-platform that referenced this issue Nov 1, 2023
@DanielVZ96
chore: ignore import ABCs from 'collections' warning
ef0a9c0 
related issue: openedx#33584

note: this warning is from a third party library (libsass)
DanielVZ96 added a commit to DanielVZ96/edx-platform that referenced this issue Nov 1, 2023
@DanielVZ96
chore: replace newrelic add_custom_parameter deprecated method
72be481 
related issue: openedx#33584

note: it has been replaced with add_custom_attribute. it is just a rename
https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-80300/
@Agrendalath
Copy link
Member

Resolved by #33601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Agrendalath @DanielVZ96