-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respond with useful information when cert is requsted #34491
Conversation
This change simply makes the lms respond with useful data/status when learner request for generating a certficate is met. This might not have been an issue before (by before we refer to the time when the learning expirence wasn't handled by the MFE but through Django template base/server side rendering) however currnelly (to my observation) this view is being only requested as a RESTful by the MFE, thus this change transform it a RESTful type of view. This change goes hand in hand with the learning MFE: - openedx/frontend-app-learning/pull/1348
Thanks for the pull request, @ghassanmas! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @ghassanmas! Just checking in to see if you plan to pursue this pull request? |
Closing this for now - we can reopen in the future if needed. |
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This change simply makes the lms respond with useful data/status
when learner request for generating a certficate is met.
This might not have been an issue before (by before we refer to
the time when the learning expirence wasn't handled by the MFE
but through Django template base/server side rendering) however
currnelly (to my observation) this view is being only requested
as a RESTful by the MFE, thus this change:
This change goes hand in hand with the learning MFE:
More info/context is to be to come
Todo list: