Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Course team members are included in "Learners in the track" emails recipients #34609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

Description

This applies to bulk emails.

audit

To reproduce the problem follow these steps:

  1. By instructor for to Instructor
  2. Email
  3. Choose Learners in the Audit track or Learners in the Verified track, fill in all necessary fields
  4. Send an email
  5. Email received by instructor user who is in the corresponding track

Expected Result

Probably course team users should be excluded from those emails to "Learners in the corresponding track" same as they are excluded from emails sent to All learners.

https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/manage_live_course/bulk_email.html#who-is-included-in-each-recipient-group

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 25, 2024

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov force-pushed the selection-of-users-for-sending-email branch 8 times, most recently from 28455f7 to 0b6d774 Compare April 25, 2024 12:50
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label May 16, 2024
Course team members are included in "Learners in the track"
emails recipients.
@DmytroAlipov DmytroAlipov force-pushed the selection-of-users-for-sending-email branch from 0b6d774 to cf20f90 Compare July 31, 2024 11:43
@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 friendly ping

@mphilbrick211
Copy link

@mphilbrick211 friendly ping

Hi @DmytroAlipov! We have this out to the community for review. Thank you for your patience.

@farhaanbukhsh
Copy link
Member

@mphilbrick211 I can take the review on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants