Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve constraint comments and tasking #35004

Closed
robrap opened this issue Jun 18, 2024 · 3 comments
Closed

Improve constraint comments and tasking #35004

robrap opened this issue Jun 18, 2024 · 3 comments

Comments

@robrap
Copy link
Contributor

robrap commented Jun 18, 2024

Improve the comments and tasking for constraints in https://github.com/openedx/edx-platform/blob/master/requirements/constraints.txt to make it simpler to track how and when constraints could be removed.

  • Read Update OEP-18 Python Dependency Management with more constraint tips open-edx-proposals#332 for some ideas.
    • This work is not blocked on the OEP proposal, and better yet, would help prove out what the proposal might be.
  • My hypothesis is that including dates in the comments would make it simpler to spot really outdated constraints.
  • What constraint removal do we want to task or not-task? For example, maybe Django upgrades don't need to be tasked, or maybe we have epic for future upgrade work?
  • We don't have to land all updates at once. We could iteratively improve this file. But, the sooner the better, so that others might copy/paste the patterns.
  • Consider adding additional README docs for what to do at the top of the file.
  • Once this work is done, consider ticketing the same work to update common_constraints.txt as well.
@jristau1984
Copy link
Contributor

@iamsobanjaved the hope is that Arbi-BOM can field this ticket, does that sound reasonable?

@iamsobanjaved
Copy link
Contributor

is this issue a duplicate of #35055 ?

@robrap
Copy link
Contributor Author

robrap commented Aug 6, 2024

Thanks @iamsobanjaved. I guess I forgot and couldn't find this when I re-tasked. Closing this ticket in favor of #35055.

@robrap robrap closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants