Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrading api to use drf 5th api. register_and_enroll_students api #35084

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Jul 3, 2024

Issue for tracking.

Updating api code using DRF.

  1. Added permission_classes

Steps to verify

  1. ALLOW_AUTOMATED_SIGNUPS set this to True in lms/djangoapps/instructor/settings/common.py
  2. View the live version of your course.
  3. Select Instructor, and then select Membership.
  4. Upload the attached csv file test.csv.

Screenshot 2024-08-07 at 9 06 40 PM

@awais786 awais786 changed the title Upgrading api drf 2 Upgrading api to use drf Jul 3, 2024
@awais786 awais786 changed the title Upgrading api to use drf feat: Upgrading api to use drf Jul 19, 2024
@awais786 awais786 changed the title feat: Upgrading api to use drf feat: 2nd. Upgrading api to use drf Jul 19, 2024
@awais786 awais786 force-pushed the upgrading-api-drf-2 branch 2 times, most recently from b21a992 to 9363631 Compare July 30, 2024 09:20
@awais786 awais786 changed the title feat: 2nd. Upgrading api to use drf feat: Upgrading api to use drf 5th api Aug 7, 2024
@awais786 awais786 closed this Aug 7, 2024
@awais786 awais786 reopened this Aug 7, 2024
@awais786 awais786 changed the title feat: Upgrading api to use drf 5th api feat: Upgrading api to use drf 5th api. register_and_enroll_students api Aug 7, 2024
@awais786 awais786 marked this pull request as ready for review August 7, 2024 16:14
@awais786 awais786 requested a review from feanil August 7, 2024 16:18
@awais786
Copy link
Contributor Author

awais786 commented Aug 9, 2024

@feanil Please review

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged.

@awais786 awais786 merged commit 6bcbb1d into master Aug 19, 2024
49 checks passed
@awais786 awais786 deleted the upgrading-api-drf-2 branch August 19, 2024 09:25
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rediris pushed a commit to gymnasium/edx-platform that referenced this pull request Aug 27, 2024
…api (openedx#35084)

* feat: upgrading simple api to drf compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants