-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content search last_published date [FC-0059] #35195
fix: content search last_published date [FC-0059] #35195
Conversation
Thanks for the pull request, @pomegranited! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
to add support for get_last_publish for components
f8b8634
to
2dd0d10
Compare
…dex-last_published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work @pomegranited !
- I tested this using the instructions from PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
@@ -441,7 +441,7 @@ def test_build_library_object_tree(self) -> None: | |||
""" | |||
Test if we can export a library | |||
""" | |||
with self.assertNumQueries(11): | |||
with self.assertNumQueries(8): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works well @pomegranited ! I just had run the reindex the first time before being able to do the sorting (which is expected, but the order of the testing instructions had the reindexing at the end)
- I tested this: Followed the testing instruction in the PR
- I read through the code
-
I checked for accessibility issues -
Includes documentation
(Approved, but please squash.) |
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
#35103 mis-used the "last published" log to determine the component published date. openedx/openedx-learning#204 resolves this issue by providing a new property
component.versions.last_publish_log
, from which we can get thepublished_at
datetime.Supporting information
Depends on openedx/openedx-learning#204
Private-ref: FAL-3758
Testing instructions
python manage.py cms reindex_studio --experimental
Or you can just reindex studio content to apply this change to existing components:
Deadline
None