-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add default setting DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR #35208
base: master
Are you sure you want to change the base?
feat: Add default setting DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR #35208
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4630705
to
43c2ffa
Compare
@@ -1548,6 +1549,8 @@ def _make_mako_template_dirs(settings): | |||
USERNAME_REGEX_PARTIAL = r'[\w .@_+-]+' | |||
USERNAME_PATTERN = fr'(?P<username>{USERNAME_REGEX_PARTIAL})' | |||
|
|||
######## Settings for the default display behavior of course certificates ########### | |||
DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR = CertificatesDisplayBehaviors.END.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR = CertificatesDisplayBehaviors.END.value | |
# .. setting_name: DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR | |
# .. setting_default: CertificatesDisplayBehaviors.END.value | |
# .. setting_description: Default value for the `certificates_display_behavior` course field. | |
# Together with certificate_available_date it will determine when a user can see their certificate for the course. | |
DEFAULT_CERTIFICATES_DISPLAY_BEHAVIOR = CertificatesDisplayBehaviors.END.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is more informative
43c2ffa
to
ee97366
Compare
Adding a default setting will allow more flexible control over certificate creation behavior at the global level.
ee97366
to
7daf83f
Compare
Description
Adding a default setting will allow more flexible control over certificate creation behavior at the global level.
This way we can set any of the available values by default:
END
END_WITH_DATE
EARLY_NO_INFO