Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0059] feat: allow copy library v2 xblock #35211

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Jul 31, 2024

Description

This PR changes the content stage Rest API to allow copying XBlocks from Libraries V2.

Testing instructions

Follow the instructions from openedx/frontend-app-authoring#1197


Private ref: FAL-3769

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 31, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 31, 2024
@rpenido rpenido force-pushed the rpenido/fal-3769-allow-copy-clipboard-to-library-content branch from 9d01865 to cd593c3 Compare August 2, 2024 13:45
@rpenido rpenido force-pushed the rpenido/fal-3769-allow-copy-clipboard-to-library-content branch from cd593c3 to 8aa46bf Compare August 2, 2024 13:57
@rpenido rpenido changed the title [FC-0059] feat: add copy library content to clipboard (WIP) [FC-0059] feat: add copy library content to clipboard Aug 2, 2024
@rpenido rpenido force-pushed the rpenido/fal-3769-allow-copy-clipboard-to-library-content branch 2 times, most recently from b769fff to 7aa6a02 Compare August 2, 2024 14:04
@rpenido rpenido changed the title [FC-0059] feat: add copy library content to clipboard [FC-0059] feat: allow copy library v2 xblock Aug 2, 2024
@rpenido rpenido force-pushed the rpenido/fal-3769-allow-copy-clipboard-to-library-content branch from 7aa6a02 to 4e020cc Compare August 2, 2024 14:21
@rpenido rpenido marked this pull request as ready for review August 2, 2024 14:45
Copy link
Contributor

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido I faced an issue when trying to copy blocks, I needed to make the change below in order for it to work. Can you double check to see if that was indeed an issue or if I am doing something wrong on my end?

openedx/core/djangoapps/content_staging/views.py Outdated Show resolved Hide resolved
Co-authored-by: Yusuf Musleh <yusuf@opencraft.com>
@rpenido
Copy link
Contributor Author

rpenido commented Aug 4, 2024

@rpenido I faced an issue when trying to copy blocks, I needed to make the change below in order for it to work. Can you double check to see if that was indeed an issue or if I am doing something wrong on my end?

You're right @yusuf-musleh! Thank you for catching this!
Fixed here: 942fc91

Copy link
Contributor

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @rpenido Thanks for the fix! Everything is working well.

  • I tested this: I followed the testing instructions in the frontend PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bradenmacdonald bradenmacdonald merged commit aa952c9 into openedx:master Aug 8, 2024
49 checks passed
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3769-allow-copy-clipboard-to-library-content branch August 8, 2024 16:31
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants