Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable roll-forward of flex grading #32584

Merged
merged 10 commits into from
Jul 7, 2023

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Jun 26, 2023

Description

Add ability to roll-forward ORA flex peer grading feature.

When enabled for an Organization or course, flex peer grading will be turned on at the course level for new course reruns.

When disabled for an Organization or course, flex peer grading setting will be unmodified from default (for new course) or previous (for rerun) value.

Supporting information

JIRA: https://2u-internal.atlassian.net/browse/AU-1289

Testing instructions

Regression behavior:

  1. Create a rerun of a course using example API requests.
  2. The FEATURE NAME TBD value on the course should be false.

Negative case:

  1. Create a new Organization override in HomeWaffle_UtilsWaffle flag org overrides called openresponseassessment.force_on_flexible_peer_grading. Set to FORCE OFF.
  2. Create a rerun of a course using example API requests.
  3. The FEATURE NAME TBD value on the course should be FALSE.

New behavior:

  1. Create/edit an Organization override in HomeWaffle_UtilsWaffle flag org overrides called openresponseassessment.force_on_flexible_peer_grading. Set to FORCE ON.
  2. Create a rerun of a course using example API requests.
  3. The FEATURE NAME TBD value on the course should be TRUE.

Other information

Dependencies:

  • Work in AU-1269 to establish the field in course metadata.

@nsprenkle nsprenkle force-pushed the aurora/rerun-config-flex-grading branch 2 times, most recently from d57a6ed to fe677c8 Compare July 6, 2023 13:53
@nsprenkle nsprenkle marked this pull request as ready for review July 6, 2023 13:53
@nsprenkle nsprenkle force-pushed the aurora/rerun-config-flex-grading branch from fe677c8 to ae024c3 Compare July 6, 2023 19:37
@nsprenkle nsprenkle requested a review from jansenk July 6, 2023 19:37
cms/djangoapps/contentstore/toggles.py Outdated Show resolved Hide resolved
'description': 'Test roll-forward of flex grading setting',
})
source_course = self.store.get_course(self.source_course_key)
source_course.force_on_flexible_peer_openassessments = mock_original_course_setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the source_course of course!

@mock.patch(
'cms.djangoapps.contentstore.views.course.default_enable_flexible_peer_openassessments'
)
def test_default_enable_flexible_peer_openassessments_on_rerun(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great test 👍

@nsprenkle nsprenkle force-pushed the aurora/rerun-config-flex-grading branch from 8a9e6ee to c99c3a3 Compare July 7, 2023 13:59
@nsprenkle nsprenkle merged commit 452433a into master Jul 7, 2023
42 checks passed
@nsprenkle nsprenkle deleted the aurora/rerun-config-flex-grading branch July 7, 2023 14:42
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants