Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix django4 deprecation warnings in lms #32948

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Aug 9, 2023

Description

@@ -1,2 +1 @@
# lint-amnesty, pylint: disable=missing-module-docstring
default_app_config = 'lms.djangoapps.instructor_task.apps.InstructorTaskConfig'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit declaration of default_app_config was deprecated in Django 3.2 [See release notes]

@UsamaSadiq UsamaSadiq force-pushed the fix-django4-deprecation-lms-1 branch from 4d57ae6 to df7da83 Compare August 9, 2023 08:55
@UsamaSadiq UsamaSadiq marked this pull request as ready for review August 9, 2023 10:54
@UsamaSadiq UsamaSadiq force-pushed the fix-django4-deprecation-lms-1 branch from f8e16cd to 69f0f82 Compare August 15, 2023 14:46
@UsamaSadiq UsamaSadiq merged commit 4dea331 into master Aug 16, 2023
42 checks passed
@UsamaSadiq UsamaSadiq deleted the fix-django4-deprecation-lms-1 branch August 16, 2023 06:15
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mehedikhan72 pushed a commit to mehedikhan72/edx-platform that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants