Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grades event bus event handler for rejected special exam. #33412

Conversation

MichaelRoytman
Copy link
Contributor

@MichaelRoytman MichaelRoytman commented Oct 4, 2023

Description

This commit adds an event bus event handler to the grades application. This event handler handles the EXAM_ATTEMPT_REJECTED Open edX event, which is emitted when a learner's exam attempt is rejected. The event handler creates a subsection grade override, overriding the grade to 0.0.

Supporting information

JIRA: MST-2017 (private)

Add event-consumer to edx-platform that will call override_subsection_grade in services.py here: https://github.com/openedx/edx-platform/blob/master/lms/djangoapps/grades/services.py#L30 upon consumption.

This consumer should be added to handlers.py (please make this file if it does not exist).

Event Definitions: openedx/openedx-events#268
Decision Record: Implementation of Event Driven Architecture for Exam Downstream Effects

Testing instructions

  1. Set up the event bus as described in How to start using the Event Bus.
  2. Set up edx-exams.
  3. Create a proctored exam in Studio.
  4. Take the proctored exam as a learner in the LMS.
  5. As an admin, mark the exam attempt as rejected.
  6. Check that the learner receives a subsection grade override of 0.0.

Deadline

None.

Other information

None.

@MichaelRoytman MichaelRoytman changed the title feat: add grades event bus event handler for rejected special exam Add grades event bus event handler for rejected special exam. Oct 4, 2023
@MichaelRoytman MichaelRoytman force-pushed the MichaelRoytman/MST-2107-EXAM_ATTEMPT_REJECTED-consumer branch 3 times, most recently from a30d161 to 22c8011 Compare October 4, 2023 18:04
@alangsto alangsto force-pushed the alangsto/verified_event_consumer branch from 0ec31dd to dc0effc Compare October 4, 2023 18:43
@MichaelRoytman MichaelRoytman force-pushed the MichaelRoytman/MST-2107-EXAM_ATTEMPT_REJECTED-consumer branch from 22c8011 to 087c50d Compare October 4, 2023 19:31
Copy link
Contributor

@Zacharis278 Zacharis278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lms/djangoapps/grades/signals/handlers.py Show resolved Hide resolved
@alangsto alangsto force-pushed the alangsto/verified_event_consumer branch from dc0effc to 9574690 Compare October 5, 2023 16:50
Base automatically changed from alangsto/verified_event_consumer to master October 5, 2023 18:54
This commit adds an event bus event handler to the grades application. This event handler handles the EXAM_ATTEMPT_REJECTED Open edX event,
 which is emitted when a learner's exam attempt is rejected. The event handler creates a subsection grade override, overriding the grade to
 0.0.
@MichaelRoytman MichaelRoytman force-pushed the MichaelRoytman/MST-2107-EXAM_ATTEMPT_REJECTED-consumer branch from 087c50d to b4cb93e Compare October 5, 2023 19:18
@MichaelRoytman MichaelRoytman merged commit a313b3f into master Oct 5, 2023
62 checks passed
@MichaelRoytman MichaelRoytman deleted the MichaelRoytman/MST-2107-EXAM_ATTEMPT_REJECTED-consumer branch October 5, 2023 19:48
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants