Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Course blocks API with param return_type=list 34379 #34426

Conversation

qasimgulzar
Copy link
Contributor

Issue Description

Version: Quince.1
Discussion: edx (New).
Endpoint: {LMS_HOST}/api/courses/v1/blocks/?course_id={COURSE_ID}&return_type=list

Console log:

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 26, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @qasimgulzar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim backport PR backports a change from main to a named release. labels Mar 26, 2024
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 28, 2024
@e0d
Copy link
Contributor

e0d commented Mar 28, 2024

Tests have passed, removing the flag.

@mphilbrick211 mphilbrick211 requested a review from a team March 28, 2024 20:58
@jsnwesson
Copy link
Contributor

@mphilbrick211 Looks like the Aurora team owns this Course API, so i'll be pinging them to be aware of this PR!

@mphilbrick211
Copy link

@mphilbrick211 Looks like the Aurora team owns this Course API, so i'll be pinging them to be aware of this PR!

Thanks, @jsnwesson, though I don't think Aurora is reviewing these anymore.

@jsnwesson
Copy link
Contributor

Approving/merging since this was already approved/merged for the master branch in #34424 , apologies for leaving this hanging for so long!

@jsnwesson jsnwesson merged commit d91cadf into openedx:open-release/quince.master May 10, 2024
43 checks passed
@openedx-webhooks
Copy link

@qasimgulzar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants