Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respond with useful information when cert is requsted #34491

Closed
wants to merge 1 commit into from

Conversation

ghassanmas
Copy link
Member

@ghassanmas ghassanmas commented Apr 9, 2024

This change simply makes the lms respond with useful data/status
when learner request for generating a certficate is met.

This might not have been an issue before (by before we refer to
the time when the learning expirence wasn't handled by the MFE
but through Django template base/server side rendering) however
currnelly (to my observation) this view is being only requested
as a RESTful by the MFE, thus this change:

  • Transform it a RESTful type of view.
  • Send useful information to the client back when exists

This change goes hand in hand with the learning MFE:

More info/context is to be to come

Todo list:

  • restrucuture/review the wording of code comments
  • add more context about the appraoch
  • add screen recorading for before and after fix
  • add info for how to test/replicate
  • one implementation is okyed by maintainer(s) check for tests

 This change simply makes the lms respond with useful data/status
 when learner request for generating a certficate is met.

  This might not have been an issue before (by before we refer to
  the time when the learning expirence wasn't handled by the MFE
  but through Django template base/server side rendering) however
  currnelly (to my observation) this view is being only requested
  as a RESTful by the MFE, thus this change transform it a
  RESTful type of view.

  This change goes hand in hand with the learning MFE:
   - openedx/frontend-app-learning/pull/1348
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 9, 2024

Thanks for the pull request, @ghassanmas!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 12, 2024
@mphilbrick211
Copy link

Hi @ghassanmas! Just checking in to see if you plan to pursue this pull request?

@mphilbrick211
Copy link

Closing this for now - we can reopen in the future if needed.

@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants