feat: emit new course passing status events #34524
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kyrylo-kh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
| """ | ||
| self.receiver_called = True | ||
|
|
||
| def test_ccx_course_passing_status_updated_emitted(self): |
There was a problem hiding this comment.
Please add a docstring to this test case
| """ | ||
| self.receiver_called = True | ||
|
|
||
| def test_course_passing_status_updated_emitted(self): |
There was a problem hiding this comment.
Please add docstring to this test case as well
| @@ -209,6 +257,45 @@ def course_grade_now_failed(user, course_id): | |||
| } | |||
| ) | |||
|
|
|||
| # produce to event bus | |||
There was a problem hiding this comment.
Can this be moved to the utility function, so the condition for checking course type isn't duplicated?
|
@kyrylo-kh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This pull request waits for merging openedx-events PR. Once it will be merged corresponding requirements will be added and unit-tests wil work.
Description
Add new event bus events to produce related to grades and badges.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.