Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support to Group Configuration view for Teams partitions #34643

Merged
merged 2 commits into from
May 6, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Apr 26, 2024

Description

This PR adds support for viewing Content Groups associated with teams in Studio's Group Configurations view. Before this change, after turning the content groups + teams connection on, the view didn't render correctly:

Screencast.from.26-04-24.12.12.57.mp4

Although partitions and their groups were displayed, the frontend implementation only supported one partition per scheme. This PR supports multiple partitions per scheme by using the partition ID:

image

Also, it modifies the team partition scheme to be read-only, so the user doesn't modify it since partitions are created dynamically.

Supporting information

Following up: #33788

Testing instructions

Testing instructions

  1. After creating your course, you'll need to turn on a course-level flag that enables content groups for teams:
    Go to /admin/waffle_utils/waffleflagcourseoverridemodel
    Add new flag using your new course ID: teams.content_groups_for_teams

  2. Enable teams for the course: Studio > Select course > Content > Pages & resources > Teams > Teams toggle
    image

  3. Create a few team sets (or groups) from the Course Authoring MFE for your course:
    image

  4. Then, go to the LMS and create a few teams within those team-set (or topics, or groups):
    image
    image

  5. Go to the Group Configurations view in Studio for the course you just configured.

Deadline

This effort is part of the Spanish consortium project, so it'd be ideal to merge this before the end of the project.

Other information

More technical info on teams: https://openedx.atlassian.net/wiki/spaces/AC/pages/160611195
Course author docs on teams: https://edx.readthedocs.io/projects/edx-partner-course-staff/en/latest/course_features/teams/teams_setup.html#teams-overview

PR Sandbox

Settings

TUTOR_GROVE_WAFFLE_FLAGS:
- name: teams.content_groups_for_teams
  everyone: true
- name: teams.enable_teams_app
  everyone: true

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 26, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 26, 2024

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix-team-groups-config-view branch 2 times, most recently from 7fe3838 to c32514d Compare April 26, 2024 16:03
@mariajgrimaldi mariajgrimaldi changed the title feat: add support to Group Configuration view for Teams partitions fix: add support to Group Configuration view for Teams partitions Apr 26, 2024
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix-team-groups-config-view branch from c32514d to dcdad95 Compare April 26, 2024 16:06
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review April 26, 2024 16:42
@felipemontoya
Copy link
Member

Since we're adding a new entrypoint to the setup.py file, you should connect to your LMS/CMS containers and run: pip install -e .

@mariajgrimaldi is this part of the testing instructions necessary? Since the entrypoint is already in master and the nighly image should contain this already I would expect that the entrypoint is already isntalled by the time I switch branches, isn't it?

@mariajgrimaldi
Copy link
Member Author

@felipemontoya: yes, not needed. I copy pasted the instructions from the other PR.

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This PR looks good to me. Moving the partition to read only makes them show nicely in the UI and the list of places where the partition is used is correct.

@kdmccormick kdmccormick added the create-sandbox open-craft-grove should create a sandbox environment from this PR label May 6, 2024
@kdmccormick kdmccormick self-assigned this May 6, 2024
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick kdmccormick removed their assignment May 6, 2024
@mariajgrimaldi mariajgrimaldi merged commit b792222 into master May 6, 2024
66 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/fix-team-groups-config-view branch May 6, 2024 15:46
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants