Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paver Removal 2/3 #34830

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented May 21, 2024

Description

  • Removes all remaining Paver commands except the miscellaneous quality checks. Removed commands:
    • pavelib/prereqs.py:*
    • pavelib/assets.py:*
  • Removes ./manage.py [lms|cms] compile_sass, which was just a wrapper around Paver commands.
  • Removes paver from base requirements, as it's only needed for testing now.

Supporting info

This is part of:

Previous work (blocking this):

Next PR:

Testing instructions

None. For the community deployment, this is all dead code. The replacement (npm run) was thoroughly tested as part of the linked DEPR ticket.

Merge considerations:

  • We're eager to merge this as it will deliver a ~1-2min build-time improvement for prod images, as libsass will no longer be part of the platform's base requirements. No change for dev images, though, as libsass is still needed by development requirements.
  • This is currently blocked on coordination with early deployers (2U). More details TBD.

As of Python 3.3, the 3rd-party 'mock' package has been subsumed into
the standard 'unittest.mock' package. Refactoring tests to use the
latter will allow us to drop 'mock' as a dependency, which is currently
coming in transitively through paver.in.
These packages were installed transitively through paver.in, but they
are used as direct dependencies in edx-platform application code:

* psutil
* pymemcache
* wrapt

Since we are demoting paver.in to be a dev-only dependency (with plans
to remove paver.in entirely), we need to make those three packages
explicit dependencies in kernel.in

Part of: openedx#34467
kdmccormick and others added 2 commits May 22, 2024 12:00
Commit generated by workflow:
`kdmccormick/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master`

Co-authored-by: Kyle McCormick <kyle@axim.org>
kdmccormick added a commit that referenced this pull request May 22, 2024
As of Python 3.3, the 3rd-party `mock` package has been subsumed into the
standard `unittest.mock` package. Refactoring tests to use the latter will
allow us to drop `mock` as a dependency, which is currently coming in
transitively through requirements/edx/paver.in.

We don't actually drop the `mock` dependency in this PR. That will happen
naturally in:

* #34830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant