-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Commerce Coordinator step in retirement pipeline #35203
feat: Commerce Coordinator step in retirement pipeline #35203
Conversation
0c21b3f
to
2eab8c2
Compare
I don't feel comfortable giving it a 👍 yet with the tests failing, but I think the approach here is great. I can see us using this to remove some of the other 2U-specific retirement pieces that already exist in the codebase too. Are there plans to update the Open edX documentation with info on this new feature? I could see it being useful for other folks in the community, or even just future us. There are so many settings and configuration pieces in the monolith that configuration options and discoverability is difficult. EDIT: Slightly worried I might send you on a wild goose chase with regards to adding new documentation. I noticed today that it seems a lot of retirement documentation exists in the |
c82835c
to
2a02bba
Compare
This reverts commit 2659ae9.
dbf8832
to
2e8f62d
Compare
2e8f62d
to
c06416b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience through this saga!
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
I believe this PR is causing our retirement pipeline to fail on requirements installation.
|
Ah, yeah. I think you're correct about needing to bump the Python version. The generic retirement feature requires the use of Django settings, and we ended up having to pull in a bunch of edx-platform requirements... which I believe are generated for Python 3.11. Many apologies here, we should have passed this by data platform first. Would you like me to prepare a revert? I'm not sure if @JadeyOlivier is still around as I believe they work out of SA, but I'm happy to get one staged. |
Switching to 3.11 resulted in different errors. |
Adding caller function for new Commerce Coordinator retirement step.