fix: update course discussion config before course load #35219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asadazam93
approved these changes
Aug 7, 2024
muhammadadeeltajamul
approved these changes
Aug 9, 2024
fix: update course discussion config before course load fix: updated unit tests fix: resolved content issue in renamed notification
AhtishamShahid
force-pushed
the
ahtisham/INF-1469
branch
from
be4caaa
to
a8fd50b
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
@AhtishamShahid it appears that this PR is causing issues when trying to load large courses. The api returns a 504 error and prevents the page from loading. I am going to revert the PR. Please reach out for more details |
KristinAoki
added a commit
that referenced
this pull request
Aug 22, 2024
…)" This reverts commit 5c09424.
KristinAoki
added a commit
that referenced
this pull request
Aug 22, 2024
rediris
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Aug 27, 2024
…edx#35219)" (openedx#35349) This reverts commit 5c09424.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure to update course discussions settings before course is loaded cms , sometimes newly created courses are not synced to real discussions settings which causes false information for the user.
Ticket
https://2u-internal.atlassian.net/browse/INF-1469