-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup constraint file and format it #35601
chore: cleanup constraint file and format it #35601
Conversation
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this very helpful. Thank you so much for these updates.
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35170 | ||
django-storages<1.14.4 | ||
|
||
# Date: 2019-08-16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not accurate (and probably won't stay accurate) because it is updated via the github action, and was updated just 2 days ago. Recommendation:
# Date: 2024 (pin updated via automation that does not update this date)
backports.zoneinfo;python_version<"3.9" # Newer versions have zoneinfo available in the standard library | ||
# Date: 2022-08-03 | ||
# pycodestyle==2.9.0 generates false positive error E275. | ||
# Constraint can be removed once the issue https://github.com/PyCQA/pycodestyle/issues/1090 is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. The dates helped. I was wondering about this since the pin was so old, and then noticed that the issue is closed, so this constraint can probably be removed.
Also noting that we don't have an issue for unpinning, but maybe we don't need one if we simply unpin. :)
PR created to close the issue #35055.