Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+18 −0
Open

feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75cceef
feat: Send message when cancel button is clicked on xblock_v2 iframe
ChrisChV Dec 13, 2024
be646df
fix: add notify() to render in xblock_v2 to fix save block
ChrisChV Dec 16, 2024
f3a1163
Merge branch 'master' into chris/advanced-editors-iframe
ChrisChV Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions common/templates/xblock_v2/xblock_iframe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,13 @@
}
return url;
},
notify: () => {
/**
* Used in `studio_view`
*
* TODO: Do nothing for now
Copy link
Contributor Author

@ChrisChV ChrisChV Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to put here yet, but it could be implemented in a separate task after the prototype is approved. I have left it empty for now, since it was not previously created for anything.

* **/
}
};

/**
Expand Down Expand Up @@ -322,5 +329,16 @@

window.addEventListener('load', blockFrameJS);
</script>
<script>
// Used when rendering the `studio_view`, in order to intercept and handle the cancel button event
document.querySelector('.cancel-button').addEventListener('click', function() {
event.preventDefault();
window.parent.postMessage('cancel-clicked', '*');
});
document.querySelector('.save-button').addEventListener('click', function() {
event.preventDefault();
window.parent.postMessage('save-clicked', '*');
});
</script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this works. Doesn't this run before the cancel button and save button are even added to the document? Are we sure this will always run after they are added ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we probably want to find some way to make this code only run in studio_view, not any other view.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: how does saving actually work? What code is handling the "Save" button and actually saving the changes?

</body>
</html>
Loading