feat: add expiration date field in credits_available serializer #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameenfatima78
force-pushed
the
sameen/ENT-7388-try2
branch
4 times, most recently
from
89727a1
to
d6018d6
Compare
fixed failing tests fixing failing tests fixed tests fix lint failures fixed isort failures
sameenfatima78
force-pushed
the
sameen/ENT-7388-try2
branch
from
d6018d6
to
6449350
Compare
|
@iloveagent57 Hi, I have incorporated your feedback in this new PR. Can you please leave a review? If all looks okay, can you please merge it too? I don't have access to merge it. |
saleem-latif
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: Add a new field "subsidy_end_date" in Credits Available response serializer.
Reason: We need this data on frontend to show when the policy is going to expire. It will be displayed against the "Available Until" header.