Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Function content_would_exceed_limit now returns no longer returns false when content price + allocations = budget limit #341

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore: Function content_would_exceed_limit now returns no longer returns false when content price + allocations = budget limit #341

merged 1 commit into from
Nov 29, 2023

Conversation

macdiesel
Copy link
Contributor

adamstankiewicz
adamstankiewicz approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iloveagent57
iloveagent57 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple testing nits.

enterprise_access/apps/subsidy_access_policy/tests/test_models.py Outdated Show resolved Hide resolved
enterprise_access/apps/subsidy_access_policy/tests/test_models.py Outdated Show resolved Hide resolved
enterprise_access/apps/subsidy_access_policy/tests/test_models.py Outdated Show resolved Hide resolved
@iloveagent57
Copy link
Contributor

also: this is technically a fix: not a chore:

@macdiesel macdiesel force-pushed the bbeggs/ENT-7991 branch 2 times, most recently from 45b4f75 to d9145c3 Compare November 29, 2023 16:20
@macdiesel macdiesel merged commit 0bd24b9 into main Nov 29, 2023
4 checks passed
@macdiesel macdiesel deleted the bbeggs/ENT-7991 branch November 29, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveagent57 iloveagent57 iloveagent57 approved these changes

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macdiesel @iloveagent57 @adamstankiewicz