Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add failed email status for reminder emails #501

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jun 25, 2024

Description:
In conjunction with the work in this PR to add failed email statuses, this PR sends a patch request to the endpoint created in edx-enterprise to update the record.

https://2u-internal.atlassian.net/browse/ENT-9040

Testing

  1. checkout both branches knguyen2/ent-9040 and feat: add failed email status for reminder emails #501
  2. create an enterprise group at http://localhost:18000/admin/enterprise/enterprisegroup/
  3. create a group membership http://localhost:18000/admin/enterprise/enterprisegroupmembership/
  4. from postman, send a patch request with body (raw) to http://localhost:18000/enterprise/api/v1/enterprise-group/<group_uuid>/learners/:
    { "learner": "edx@exampl.com", "status": "internal_api_error" }
  5. confirm that the status was updated at the endpoint http://localhost:18000/enterprise/api/v1/enterprise-group/<group_uuid>/learners/

Jira:
ENT-9040

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@katrinan029 katrinan029 marked this pull request as ready for review June 25, 2024 21:56
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katrinan029 katrinan029 merged commit 2acb140 into main Jul 1, 2024
3 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9040 branch July 1, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants