Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add policy django action to deposit funds #513

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

pwnage101
Copy link
Contributor

@pwnage101 pwnage101 commented Jul 12, 2024

ENT-9133

Screenshots

Button visible from Policy edit page:
Screenshot 2024-07-12 at 10 55 49

Form preview:
Screenshot 2024-07-12 at 10 56 16

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9133 branch 4 times, most recently from 1322640 to a0ec72b Compare July 19, 2024 19:12
@pwnage101 pwnage101 marked this pull request as ready for review July 19, 2024 19:12
Comment on lines +64 to +70
This consequence can be somewhat mitigated by consolidating all cross-service couplings into django settings, for
example (enterprise_access/settings/base.py)::

SALES_CONTRACT_REFERENCE_PROVIDER_NAME = 'Salesforce OpportunityLineItem'
SALES_CONTRACT_REFERENCE_PROVIDER_SLUG = 'salesforce_opportunity_line_item'

These values can then be referenced in custom admin forms and underlying view logic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pwnage101 pwnage101 merged commit 0550d84 into main Jul 22, 2024
3 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-9133 branch July 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants