docs: ADR on spend-limit constraint #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
force-pushed
the
hu/ent-9255
branch
6 times, most recently
from
e5a3bbb
to
a36d826
Compare
brobro10000
force-pushed
the
hu/ent-9255
branch
from
a36d826
to
3c39b29
Compare
iloveagent57
reviewed
Aug 5, 2024
iloveagent57
approved these changes
Aug 5, 2024
adamstankiewicz
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
LGTM. One minor suggestion might be to include link to this ADR here in the list of other ADRs (though it does look like the more recent ones are missing from the list).
| * Policy A, an ``active`` policy with a ``spend_limit`` of 10,000 | ||
| * Policy B, an ``active`` policy with a ``spend_limit`` of 40,000 | ||
| * If Policy A were set to ``!active`` | ||
| * Policy B's ``spend_limit`` can now be set to ``50,000`` (even if spend has occured on Policy A or B) |
There was a problem hiding this comment.
super nit: doesn't seem like other instances of numeric dollar values here (e.g., 10,000 and 40,000 above) are formatted with the backticks. could remove the backticks for consistency with other numeric values.
There was a problem hiding this comment.
Updated in this PR 👍🏽
#528
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADR on the recently introduced
spend-limitconstraint within theclean()function within thesubsidy_access_policymodelDescription:
Add a description of your changes here.
Jira:
ENT-XXXX
Merge checklist:
./manage.py makemigrationshas been runPost merge: