Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow staff users to override lms_user_id in can-redeem API #543

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Aug 19, 2024

Description:

Supports an optional lms_user_id query parameter in the can-redeem API to override the default user id used for the request. Only works if the authenticated request user is_staff=True.

http://localhost:18270/api/v1/policy-redemption/enterprise-customer/{enterprise_customer_uuid}/can-redeem/?lms_user_id=1234
image

Jira:
ENT-9291

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@adamstankiewicz adamstankiewicz force-pushed the ags/ent-9291 branch 4 times, most recently from 0432399 to bd0f609 Compare August 19, 2024 21:17
@adamstankiewicz adamstankiewicz changed the title feat: allow staff users to override lms_user_id in can-redeem API feat: allow staff users to override lms_user_id in can-redeem API Aug 19, 2024
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor nits.

@adamstankiewicz adamstankiewicz merged commit 3112bba into main Aug 20, 2024
3 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-9291 branch August 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants