Un-do all the reindex-algolia changes to improve memory consumption #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-7311-6-revert
branch
from
9cd1ae3
to
067ac71
Compare
iloveagent57
approved these changes
Jul 12, 2023
| @@ -208,7 +206,7 @@ def wrapped_task(self, *args, **kwargs): | |||
| }, | |||
| ) | |||
| raise TaskRecentlyRunError(message) | |||
| return task(self, *args, **kwargs) | |||
| return task(self, *args, *kwargs) | |||
There was a problem hiding this comment.
note to you or me: let's follow up with a small PR to correct this to **kwargs
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
Un-do all the reindex-algolia changes to improve memory consumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert c55e035 "fix: attempt to pass --dry-run correctly to task"
Revert 077f678 "fix: reindex-algolia - include UUIDs from ALL related objects"
Revert 1eb67a4 "revert: "temp: Revert reindex-algolia task changes""
ENT-7311
Description
Description of changes made
Ticket Link
Link to the associated ticket
Link title
Post-review