Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: index enrollStart and hasEnrollStart in Algolia course_runs #949

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Sep 24, 2024

  • Includes enroll_start_date in the NormalizedContentMetadataSerializer. This will persist this field in the json_metadata blob for course records.
  • Includes enroll_start in the indexed course runs metadata for course objects within Algolia; this will primarily be consumed by Admin Portal during the assignment allocation flow.

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

@@ -517,11 +529,12 @@ def test_get_upcoming_course_runs(self, searchable_course, expected_course_runs)
'max_effort': 6,
'weeks_to_complete': 6,
'seats': [{
'type': 'verified',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform] Updates the course run type to be Exec Ed when dealing with the late enrollment cases, as late enrollment is typically used with Exec Ed content.

@adamstankiewicz adamstankiewicz marked this pull request as ready for review September 24, 2024 19:38
Copy link
Contributor

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart idea to serialize this value as part of normalized metadata. Approving to unblock, but I'd also have someone else take a look at this as well, just as a sanity check 👍🏽

@adamstankiewicz adamstankiewicz merged commit 4db5daa into master Sep 24, 2024
4 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/enrollStart-algolia branch September 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants